ci: update GitHub Actions with uv setup#57
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the runner script and experiment pipeline, including modifications to filtering logic, output file naming, and workflow configurations while removing an obsolete test file.
- Removed tests/test_rewrite.py, which may affect overall test coverage
- Updated filter condition in src/hoogle.py to simplify dependency checks
- Renamed output file and updated associated documentation and workflows
- Added static analysis workflows for MyPy and Pylint support
Reviewed Changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_rewrite.py | Removed the test file; review if removal affects necessary test coverage |
| src/hoogle.py | Simplified dependency filter; ensure it behaves as expected with empty lists |
| scripts/preprocess_benchmark.py | Updated output file name; verify consumers of the file are updated accordingly |
| pyproject.toml | Added pylint dependency and pytest configuration adjustments |
| README.md | Updated commands to reflect changes in script names and output files |
| .github/workflows/unitttest.yml | Modified workflow to use uv sync and run tests via pytest |
| .github/workflows/static_check.yml | Added new workflow for type checking and linting using MyPy and Pylint |
Files not reviewed (3)
- .github/workflows/mypy.yml: Language not supported
- .github/workflows/pylint.yml: Language not supported
- .pylintrc: Language not supported
Comments suppressed due to low confidence (3)
tests/test_rewrite.py:1
- Removing test_rewrite.py may reduce test coverage for rewrite functionality. Consider adding new tests to cover the behavior previously validated by this file.
Entire file removed
scripts/preprocess_benchmark.py:11
- The output file name has been updated from 'Benchmark-F.json' to 'tfb.json'. Ensure that all documentation and downstream processes referencing this file name are updated accordingly.
def main(input_raw_benchmark_path: str = "benchmark", output_path: str = "tfb.json"):
README.md:24
- [nitpick] The command has been updated to reflect the new script and output file name. Please verify that the documentation is consistent with the changes in the preprocessing pipeline.
uv run --project . scripts/preprocess_benchmark.py
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates various runner scripts and configurations to streamline the experiment pipeline. Key changes include removing the rewrite test file, updating default output filenames and commands in scripts and documentation, and revising workflow configuration to use uv commands instead of older actions setups.
Reviewed Changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_rewrite.py | Removed test file for rewrite functionality; verify intentional removal |
| src/hoogle.py | Updated dependency check from "!= None" to "is not None" |
| scripts/preprocess_benchmark.py | Changed default output filename from "Benchmark-F.json" to "tfb.json" |
| pyproject.toml | Added pylint dependency and pytest configuration changes |
| README.md | Updated script command and instructions to reflect new file names |
| .github/workflows/unitttest.yml | Revised test workflow to install uv and run tests via pytest |
| .github/workflows/pylint.yml | Adjusted pylint workflow to use uv run for linting |
| .github/workflows/mypy.yml | Updated mypy workflow to run using uv |
Files not reviewed (1)
- .pylintrc: Language not supported
Comments suppressed due to low confidence (1)
tests/test_rewrite.py:1
- The complete removal of tests/test_rewrite.py may reduce coverage of the rewrite functionality; ensure that tests for this functionality are provided elsewhere or are intentionally deprecated.
from dacite import from_dict
EYH0602
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.